(#) Modifiers should only be used once !!! ERROR: Modifiers should only be used once This is an error. Id : `ComposeModifierReused` Summary : Modifiers should only be used once Severity : Error Category : Productivity Platform : Any Vendor : slack Identifier : com.slack.lint.compose:compose-lints Feedback : https://github.com/slackhq/compose-lints/issues Min : Lint 8.7+ Compiled : Lint 8.7+ Artifact : [com.slack.lint.compose:compose-lint-checks](com_slack_lint_compose_compose-lint-checks.md.html) Since : 1.0.0 Affects : Kotlin and Java files and test sources Editing : This check runs on the fly in the IDE editor Implementation : [Source Code](https://github.com/slackhq/compose-lints/tree/main/compose-lint-checks/src/main/java/slack/lint/compose/ModifierReusedDetector.kt) Tests : [Source Code](https://github.com/slackhq/compose-lints/tree/main/compose-lint-checks/src/test/java/slack/lint/compose/ModifierReusedDetectorTest.kt) Copyright Year : 2023 Modifiers should only be used once and by the root level layout of a Composable. This is true even if appended to or with other modifiers e.g. `modifier.fillMaxWidth()`.Use Modifier (with a capital 'M') to construct a new Modifier that you can pass to other composables.See https://slackhq.github.io/compose-lints/rules/#dont-re-use-modifiers for more information. (##) Options You can configure this lint checks using the following options: (###) content-emitters A comma-separated list of known content-emitting composables. This property should define a comma-separated list of known content-emitting composables. Example `lint.xml`: ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~xml linenumbers <lint> <issue id="ComposeModifierReused"> <option name="content-emitters" value="some string" /> </issue> </lint> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ (##) Example Here is an example of lint warnings produced by this check: ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~text src/test.kt:6:Error: Modifiers should only be used once and by the root level layout of a Composable. This is true even if appended to or with other modifiers e.g. modifier.fillMaxWidth().Use Modifier (with a capital 'M') to construct a new Modifier that you can pass to other composables.See https://slackhq.github.io/compose-lints/rules/#dont-re-use-modifiers for more information. [ComposeModifierReused] Row(modifier) { ^ src/test.kt:7:Error: Modifiers should only be used once and by the root level layout of a Composable. This is true even if appended to or with other modifiers e.g. modifier.fillMaxWidth().Use Modifier (with a capital 'M') to construct a new Modifier that you can pass to other composables.See https://slackhq.github.io/compose-lints/rules/#dont-re-use-modifiers for more information. [ComposeModifierReused] SomethingElse(modifier) ----------------------- src/test.kt:12:Error: Modifiers should only be used once and by the root level layout of a Composable. This is true even if appended to or with other modifiers e.g. modifier.fillMaxWidth().Use Modifier (with a capital 'M') to construct a new Modifier that you can pass to other composables.See https://slackhq.github.io/compose-lints/rules/#dont-re-use-modifiers for more information. [ComposeModifierReused] Column(modifier = modifier) { ^ src/test.kt:14:Error: Modifiers should only be used once and by the root level layout of a Composable. This is true even if appended to or with other modifiers e.g. modifier.fillMaxWidth().Use Modifier (with a capital 'M') to construct a new Modifier that you can pass to other composables.See https://slackhq.github.io/compose-lints/rules/#dont-re-use-modifiers for more information. [ComposeModifierReused] SomethingDifferent(modifier = modifier) --------------------------------------- src/test.kt:19:Error: Modifiers should only be used once and by the root level layout of a Composable. This is true even if appended to or with other modifiers e.g. modifier.fillMaxWidth().Use Modifier (with a capital 'M') to construct a new Modifier that you can pass to other composables.See https://slackhq.github.io/compose-lints/rules/#dont-re-use-modifiers for more information. [ComposeModifierReused] Column(modifier = modifier) { ^ src/test.kt:22:Error: Modifiers should only be used once and by the root level layout of a Composable. This is true even if appended to or with other modifiers e.g. modifier.fillMaxWidth().Use Modifier (with a capital 'M') to construct a new Modifier that you can pass to other composables.See https://slackhq.github.io/compose-lints/rules/#dont-re-use-modifiers for more information. [ComposeModifierReused] SomethingElse(modifier = modifier) ---------------------------------- src/test.kt:23:Error: Modifiers should only be used once and by the root level layout of a Composable. This is true even if appended to or with other modifiers e.g. modifier.fillMaxWidth().Use Modifier (with a capital 'M') to construct a new Modifier that you can pass to other composables.See https://slackhq.github.io/compose-lints/rules/#dont-re-use-modifiers for more information. [ComposeModifierReused] SomethingElse(modifier = modifier.padding12()) ---------------------------------------------- src/test.kt:28:Error: Modifiers should only be used once and by the root level layout of a Composable. This is true even if appended to or with other modifiers e.g. modifier.fillMaxWidth().Use Modifier (with a capital 'M') to construct a new Modifier that you can pass to other composables.See https://slackhq.github.io/compose-lints/rules/#dont-re-use-modifiers for more information. [ComposeModifierReused] SomethingElse(myMod) -------------------- src/test.kt:29:Error: Modifiers should only be used once and by the root level layout of a Composable. This is true even if appended to or with other modifiers e.g. modifier.fillMaxWidth().Use Modifier (with a capital 'M') to construct a new Modifier that you can pass to other composables.See https://slackhq.github.io/compose-lints/rules/#dont-re-use-modifiers for more information. [ComposeModifierReused] SomethingElse(myMod) -------------------- src/test.kt:34:Error: Modifiers should only be used once and by the root level layout of a Composable. This is true even if appended to or with other modifiers e.g. modifier.fillMaxWidth().Use Modifier (with a capital 'M') to construct a new Modifier that you can pass to other composables.See https://slackhq.github.io/compose-lints/rules/#dont-re-use-modifiers for more information. [ComposeModifierReused] Box( ^ src/test.kt:40:Error: Modifiers should only be used once and by the root level layout of a Composable. This is true even if appended to or with other modifiers e.g. modifier.fillMaxWidth().Use Modifier (with a capital 'M') to construct a new Modifier that you can pass to other composables.See https://slackhq.github.io/compose-lints/rules/#dont-re-use-modifiers for more information. [ComposeModifierReused] Box( ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Here is the source file referenced above: `src/test.kt`: ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~kotlin linenumbers import androidx.compose.runtime.Composable import androidx.compose.ui.Modifier @Composable fun Something(modifier: Modifier) { Row(modifier) { SomethingElse(modifier) } } @Composable fun Something(modifier: Modifier): Int { Column(modifier = modifier) { SomethingElse(modifier = Modifier) SomethingDifferent(modifier = modifier) } } @Composable fun BoxScope.Something(modifier: Modifier) { Column(modifier = modifier) { SomethingDifferent() } SomethingElse(modifier = modifier) SomethingElse(modifier = modifier.padding12()) } @Composable fun Something(myMod: Modifier) { Column { SomethingElse(myMod) SomethingElse(myMod) } } @Composable fun FoundThisOneInTheWild(modifier: Modifier = Modifier) { Box( modifier = modifier .size(AvatarSize.Default.size) .clip(CircleShape) .then(colorModifier) ) { Box( modifier = modifier.padding(spacesBorderWidth) ) } } ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ You can also visit the [source code](https://github.com/slackhq/compose-lints/tree/main/compose-lint-checks/src/test/java/slack/lint/compose/ModifierReusedDetectorTest.kt) for the unit tests for this check to see additional scenarios. The above example was automatically extracted from the first unit test found for this lint check, `ModifierReusedDetector.errors when the modifier parameter of a Composable is used more than once by siblings or parent-children`. To report a problem with this extracted sample, visit https://github.com/slackhq/compose-lints/issues. (##) Including !!! This is not a built-in check. To include it, add the below dependency to your project. This lint check is included in the lint documentation, but the Android team may or may not agree with its recommendations. ``` // build.gradle.kts lintChecks("com.slack.lint.compose:compose-lint-checks:1.4.2") // build.gradle lintChecks 'com.slack.lint.compose:compose-lint-checks:1.4.2' // build.gradle.kts with version catalogs: lintChecks(libs.compose.lint.checks) # libs.versions.toml [versions] compose-lint-checks = "1.4.2" [libraries] # For clarity and text wrapping purposes the following declaration is # shown split up across lines, but in TOML it needs to be on a single # line (see https://github.com/toml-lang/toml/issues/516) so adjust # when pasting into libs.versions.toml: compose-lint-checks = { module = "com.slack.lint.compose:compose-lint-checks", version.ref = "compose-lint-checks" } ``` 1.4.2 is the version this documentation was generated from; there may be newer versions available. [Additional details about com.slack.lint.compose:compose-lint-checks](com_slack_lint_compose_compose-lint-checks.md.html). (##) Suppressing You can suppress false positives using one of the following mechanisms: * Using a suppression annotation like this on the enclosing element: ```kt // Kotlin @Suppress("ComposeModifierReused") fun method() { problematicStatement() } ``` or ```java // Java @SuppressWarnings("ComposeModifierReused") void method() { problematicStatement(); } ``` * Using a suppression comment like this on the line above: ```kt //noinspection ComposeModifierReused problematicStatement() ``` * Using a special `lint.xml` file in the source tree which turns off the check in that folder and any sub folder. A simple file might look like this: ```xml <?xml version="1.0" encoding="UTF-8"?> <lint> <issue id="ComposeModifierReused" severity="ignore" /> </lint> ``` Instead of `ignore` you can also change the severity here, for example from `error` to `warning`. You can find additional documentation on how to filter issues by path, regular expression and so on [here](https://googlesamples.github.io/android-custom-lint-rules/usage/lintxml.md.html). * In Gradle projects, using the DSL syntax to configure lint. For example, you can use something like ```gradle lintOptions { disable 'ComposeModifierReused' } ``` In Android projects this should be nested inside an `android { }` block. * For manual invocations of `lint`, using the `--ignore` flag: ``` $ lint --ignore ComposeModifierReused ...` ``` * Last, but not least, using baselines, as discussed [here](https://googlesamples.github.io/android-custom-lint-rules/usage/baselines.md.html).